Fix sorting issue with memo and virtualization #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When using `memoMode = "row"` and table virtualization, when sorting a column, row positioning may not be correctly updated if the row existed (in DOM?) before the sort AND after the sort. Fix: Add additional check to `propsAreEqual` function for the `Memo_MRT_TableBodyRow` to check if the row index has changed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
See issue here: https://codesandbox.io/s/lucid-bessie-vohfsb?file=/src/TS.tsx EDIT: Sort the first name column a few times and you'll see some discrepancies. |
|
Wonder if we should also add the row |
I can't say I'm too acquainted with all the inner workings of the project, but it would seem I think the existing object reference check Thanks for this project btw, amazing OOTB capabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using
memoMode = "row"and table virtualization, when sorting a column, row positioning may not be correctly updated if the row existed (in DOM?) before AND after the sort.Fix:
Add additional check to
propsAreEqualfunction forMemo_MRT_TableBodyRowto check if the row index has changed.